Button: Prepend HTTP to Buttons block links when missing protocol#47311
Merged
Button: Prepend HTTP to Buttons block links when missing protocol#47311
Conversation
|
Size Change: +21 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d70db6a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4116781516
|
9950f96 to
8080ac4
Compare
scruffian
approved these changes
Jan 30, 2023
Contributor
scruffian
left a comment
There was a problem hiding this comment.
LGTM. Should we add a test for this?
Contributor
Author
|
@scruffian I added an e2e test |
kevin940726
reviewed
Feb 3, 2023
Member
kevin940726
left a comment
There was a problem hiding this comment.
Small error in the test, others look good to me 👍 !
Member
|
this would also close #6841 |
Member
|
tested with several links; worked as expected. I also created buttons with several other protocols (git, mailto, tel, doi, and http was not prepended to them; those links still worked as expected. (note that this issue also affects image blocks - up to you whether that should be a separate PR |
634b7d2 to
c6bf594
Compare
kevin940726
approved these changes
Feb 7, 2023
Co-authored-by: Kai Hao <kevin830726@gmail.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Prepends
http://to links created using the button block which don't provide a protocol.Closes #46385
Why?
Because it provides a better UX.
How?
prependUrl()from@wordpress/url.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast