Stabilise BlockPreview props#47231
Merged
Merged
Conversation
14 tasks
|
Size Change: +264 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jan 18, 2023
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR Robert! I've left a couple of comments.
| return [ | ||
| ...styles, | ||
| ...__experimentalStyles, | ||
| ...additionalStyles, |
Contributor
There was a problem hiding this comment.
That's not from this PR, but is there a case that we don't have styles but we do have additionalStyles?
Member
Author
There was a problem hiding this comment.
Yes in theory there could be no styles attribute in the block editor settings which would mean styles is undefined here. This likely happens when the block editor is used outside of WordPress.
|
Flaky tests detected in 6e85766. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3955058016
|
Member
Author
|
Thanks @ntsekouras |
youknowriad
reviewed
Nov 9, 2023
| version: '6.4', | ||
| alternative: 'additionalStyles', | ||
| } ); | ||
| } |
Contributor
There was a problem hiding this comment.
Should we follow-up and remove these props now? If you think it's still too early, consider increasing the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes/stabilises the
__experimentalprops fromBlockPreviewin@wordpress/block-editor.Remove
__experimentalMinHeightin favour ofminHeight.This has been around for a while (Update query block creation and replacement flows #38997) and seems stable, so mark it as such.
Remove
__experimentalStylesin favour ofadditionalStyles.This was added recently (Global Styles: Add Style Book to Global Styles #45960) but I think it's quite flexible. I decided to use the word "additional" for clarity.
Remove
__experimentalPaddingin favour of passing abody { padding: ...; }style toadditionalStyles.Given
additionalStyleslets us add arbitrary styles to the iframe body, we don't need props for every CSS property including padding.Why?
#47196
Testing Instructions