Updates some spacing + dimensions in the Site Hub#47120
Merged
jameskoster merged 2 commits intotrunkfrom Jan 13, 2023
Merged
Conversation
|
Size Change: +24 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 651ee14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3904413262
|
youknowriad
approved these changes
Jan 13, 2023
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍 assuming we want to reduce the size of the site icon (which can reduce its visibility depending on what is set there)
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change did involve increasing the W button footprint to 64px in view mode, but that was essential unless we want to reduce the footprint of the whole button down to 32px which seemed like a usability trade-off. It resizes back to 60px in edit mode, and seems to work fine.