Open
Conversation
|
Size Change: +1.88 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b4623e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3975867423
|
noahtallen
reviewed
Jan 17, 2023
| RUN echo 'xdebug.start_with_request=yes' >> /usr/local/etc/php/php.ini | ||
| RUN echo 'xdebug.mode=${ enableXdebug }' >> /usr/local/etc/php/php.ini | ||
| RUN echo '${ clientDetectSettings }' >> /usr/local/etc/php/php.ini | ||
| RUN HOST_IP=$(ip route | awk '/default/ { print $3 }'); echo "xdebug.client_host=\"$HOST_IP\"" >> /usr/local/etc/php/php.ini |
Member
Author
There was a problem hiding this comment.
When PHPUnit is used, xdebug is not able to detect host ip within the docker container. It can do it through the browser because of some HTTP fields, but that doesn't exist in the CLI. The host IP is the "default gateway" within the docker container, which can be seen using the ip route command. This extracts the default gateway from the ip route command and sets it as host ip.
| volumes: developmentMounts, | ||
| }, | ||
| 'tests-wordpress': { | ||
| build: '.', |
Member
There was a problem hiding this comment.
Does this break how testsPhpVersion sets the PHP version for the tests-wordpress environment?
Member
Author
There was a problem hiding this comment.
It does. Well spotted. I changed the code now so that if testsPhpVersion is set, xdebug will not work. I don't have the time to add compatibility for that, but at least if someone does specify this in their config, they will get that php version in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
While working on #46952 I found it would be useful to be able to run xdebug in PHP unit tests. This PR makes it possible.