State: Assign default for all allowed blockTypes#4707
Merged
Conversation
Explicitly passed from top-level editor, but should be inferred from nested providers
This was referenced Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #3745
This pull request seeks to define a default value for the
EditorProviderblockTypessetting. As implemented, this is only respected if explicitly provided. This is true for the top-level editor, passed from the server-sideclient-assets.phpscript enqueuing, but as discovered in the original implementation of #3745 with nested editor providers, would result in an error if not provided. The changes here provide this default which, while not currently used, reduces fragility of the provider usage.Testing instructions:
There should be no changes in behavior, specifically note lack of regressions in behavior of allowed block types.