Synchronize the canvas mode with the site editor url#47002
Merged
Conversation
|
Size Change: +110 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 30cd999. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3882128072
|
jameskoster
approved these changes
Jan 10, 2023
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
This feels right to me.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #36667
What?
This PR updates the site editor to persist the "edit mode" in the URL. So for instance if you're in edit mode and refresh the page, you get back to the same state.
Why?
Testing Instructions
1- Load the site editor
2- Enter edit mode
3- Reload the page
4- you should stay in "edit" mode.