Jest config: use real timers by default#46714
Merged
Conversation
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 22, 2022
Member
Author
Yes. I'd like to first review and merge #46713, and only then rebase this one on top of |
d15ead7 to
5fdd5e4
Compare
Member
Author
|
The There are just two tests ( |
tyxla
approved these changes
Dec 22, 2022
Member
tyxla
left a comment
There was a problem hiding this comment.
This is amazing, thank you Jarda 🚀
Left a few remarks, but nothing is blocking. I'd only prefer adding a CHANGELOG entry for the jest default preset change before shipping.
| ], | ||
| testPathIgnorePatterns: [ '/node_modules/', '<rootDir>/vendor/' ], | ||
| timers: 'fake', | ||
| timers: 'real', |
Member
There was a problem hiding this comment.
This looks like it will need a CHANGELOG entry. For some relying on fake timers to be the default, this might be a breaking change.
Member
Author
There was a problem hiding this comment.
I'll return to this in a followup. Now my goal is to:
- land this real timers change
- make
useSelectwithuseSyncExternalStorepass all the tests and merge it - try out the "enable concurrent mode" PR with the new
useSelect, to see if the current e2e failures disappear or not
| await user.clear( input ); | ||
| await user.type( input, 'Foo Bar-Baz 9!' ); | ||
| input.blur(); | ||
| act( () => input.blur() ); |
Member
There was a problem hiding this comment.
Maybe we could just trigger a tab and that'd blur it anyway, but in a way resembling user behavior more closely?
| describe( 'PostSlug', () => { | ||
| it( 'should update slug with sanitized input', async () => { | ||
| const user = userEvent.setup( { | ||
| advanceTimers: jest.advanceTimersByTime, |
Member
There was a problem hiding this comment.
We might have to remove that in more places where it's not necessary.
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the default timers used by Jest unit tests from
faketoreal. That should unblock theuseSelectreimplementation in #46538 whose unit tests are now failing because of a React bug (facebook/react#25889). Changing the default works around that bug and should make the unit tests green again.The patch adds an explicit
jest.useFakeTimers()call to all tests that use fake timers explicitly, i.e., use a Jest API to run the fake timers.The
BorderControltest required somewhat more complex changes, which I'm proposing separately in #46713.