Popover: check positioning by adding and testing is-positioned class#46429
Merged
Popover: check positioning by adding and testing is-positioned class#46429
Conversation
This was referenced Dec 9, 2022
|
Size Change: +15 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 9, 2022
Member
tyxla
left a comment
There was a problem hiding this comment.
I like the change 👍 Given that we have various different ways to position a popover, and various reasons to check if a popover has been positioned, this is going to be very handy.
🚀
Member
Author
|
As a follow-up, we could also take animation state into account and set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
Popovercomponent is finished positioning, i.e., when theuseFloatinghook from thefloating-uilibrary returns validxandycoordinates, add ais-positionedCSS class on the popover element.This is then used by the
.toBePositionedPopoverhelper to detect a positioned popover. We don't need to check the exact styles, which are an implementation detail that can change. Like it does in #46187.Closes #46303.