Closed
Conversation
|
Size Change: -7 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 2, 2022
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
Thanks for this. This feels like a more solid starting point, and as noted in several other threads, we can iterate and revisit more easily from this basis!
Contributor
Author
|
Thanks for reviewing! I'll close this one out since #46139 has landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR splits out the
flex-shrinkremoval from #46139, in case it's desirable to land that change before dealing with theflex-basisdefault value, which is being discussed in that PR.Why?
The change in #46139 has some nuance surrounding what to do with pre-populating
flex-basisvalues, so it might be easier to try to land theflex-shrinkremoval first. Removingflex-shrinkwas discussed earlier over in: #45364 (comment)How?
flex-shrinkrule fromlayout.phpandlayout.jswhen outputting theflexSizevalue.Testing Instructions
Screenshots or screencast
500px)