Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Size Change: -725 B (0%)

Total Size: 1.31 MB

_{compressed-size-action}

@tyxla, our policy on removing deprecated APIs and props has changed recently, so I'm not entirely sure that we can remove these props.

Here's a recent example #45195 (comment) and you can find general conversations in this issue #40316.

Thanks for letting me know @Mamaduka!

I wonder what alternatives we have? Punt the decision for 6 more months of releases by just bumping the version?

@Mamaduka would that policy apply also for experimental props like the ones being discussed in this PR?

I wonder what alternatives we have?

Off the top of my mind:

• bumping the deprecation version as @tyxla suggested would be just a way to gain some time here (and fix broken CI tests on trunk)
• a more gradual approach could be:
  • add __nextRemoveHelpButton and __nextRemoveResetButton props to all usages of DateTimePicker across the repo
  • change their default value from false to true, effectively removing help and reset buttons from the default version of the component (potentially breaking change)
  • finally, we could see if we can remove the props (and related code) completely, or if we had to leave them around to support backward compat

Okay, I've filed #46006 to bump the removal version of the deprecated props. That gives us some time to think about it better while the checks in trunk are green. I suggest going with that until we can figure out a better way to deal with the growing number of deprecated features cluttering the code.