Conversation
|
|
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Nov 18, 2022
| await user.click( screen.getByRole( 'button', { name: 'close' } ) ); | ||
|
|
||
| expectPopoverVisible( dropdownContainer, false ); | ||
| expect( screen.queryByTestId( 'popover' ) ).not.toBeInTheDocument(); |
Contributor
There was a problem hiding this comment.
no need to call unmount here because the popover is closed, right ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR is improving the existing tests of the
Dropdowncomponent. Easiest to review commit-by-commit.Why?
My initial motivation was to just address a few pre-existing
no-node-accessESLint violations but ended up fixing a few other issues that make the tests ultimately more readable and reliable.How?
We're basically doing a few improvements, which I've tried to keep in separate commits:
screenqueries.no-node-accessviolations by introducing adata-testidto locate the popover withscreenqueries, or simply usingscreenqueries where that was directly achievable.userEventinstead offireEventto simulate user events better and closer to what the user actually experiences.Testing Instructions
Verify tests still pass.