Template Part Block: use icon for area selection (take 2)#45764
Closed
creativecoder wants to merge 2 commits intotrunkfrom
Closed
Template Part Block: use icon for area selection (take 2)#45764creativecoder wants to merge 2 commits intotrunkfrom
creativecoder wants to merge 2 commits intotrunkfrom
Conversation
|
|
This was referenced Nov 15, 2022
|
Size Change: +32 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks for working on this. Should the icon in the block toolbar also update when you change the area? |
|
Copy looks good! Only thing I'd suggest for the mouseover language is to go with either: • The area of a page this block occupies If it's possible to put a header anywhere, then I'd go with the second option. ("Should" is fine too, but "usually" might be a little bit friendlier.) |
Contributor
|
Testing using the Gutenberg PR build. https://make.wordpress.org/design/2021/03/03/testing-a-gutenberg-pull-request-pr/ Before
After
As James mentions
This would be helpful as the icon in the toolbar gives an extra visual confirmation that the specific area has changed to general, header or footer template area. I added the accessibility label as it would be good to get accessible feedback. |
Contributor
|
I would like to review this for accessibility, but I am not sure this part of the editor is actually accessible enough at this point. How about this. Can someone list steps on how I could test this with the keyboard? If you cannot list those steps, it is likely not accessible enough for me to test with my screen reader. Thanks. |
Contributor
|
@creativecoder are you planning to continue working on this? :) |
|
Hi @jameskoster, can we have the "needs copy review" label removed from this PR? It keeps popping up in our Slack channel as a requirement. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-attempt from #30005
What?
Changes the Template Part block "Area" setting to use icons, giving a more visual representation of the setting.
Why?
Addresses #29295
How?
Changes the setting to use a toggle group with icons instead of a dropdown selector.
Testing Instructions
Screenshots or screencast