Site Editor: Enable copy/cut shortcut#45752
Merged
Merged
Conversation
|
|
|
Size Change: +12 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
9 tasks
jorgefilipecosta
approved these changes
Jan 3, 2023
jorgefilipecosta
left a comment
Member
There was a problem hiding this comment.
I think this PR is a good fix and should be merged after a rebase 👍 I did not found issues on my tests.
Contributor
Author
|
Thank you for your review, @jorgefilipecosta! |
|
On Firefox on Windows 10, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43709
Related to #43352
What?
This PR activates copy/cut shortcut in the site editor.
Why?
When I was looking into the shortcut issue in Windows with #43352, I noticed that copy/cut shortcut is not available only for the site editor:
I was unable to find if this shortcut was intentionally opted out, but I think shortcuts should be as uniform as possible in all editor instances.
How?
Added the
useClipboardHandlerhook to the site editor ref. Please advise me if you have any concerns about adding this hook.Testing Instructions
Confirm that the copy and cut shortcuts work in all of the following locations. It is also a good idea to check the paste shortcut at the same time.
Screenshots or screencast
f01b8b50397bf19e17bb556f46ba1ba6.mp4