Table block: Fix error in margin value#45674
Merged
andrewserong merged 1 commit intotrunkfrom Nov 9, 2022
Merged
Conversation
|
|
|
Size Change: -23 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Nov 9, 2022
Contributor
getdave
left a comment
There was a problem hiding this comment.
Could not replicate on TT3 but was able to replicate on TT2.
Contributor
Author
|
Thanks for testing @getdave! It looks like TwentyTwentyThree doesn't opt in to the block styles theme support which outputs the extra rules in the |
Contributor
|
Could this be backported to 6.1.2? |
Contributor
|
Yes, backport this to WP 6.1.2, please |
+1 to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
As highlighted in #43813 there was a typo in the margin value for the table block's CSS. This PR resolves it.
Why?
Ensure we have valid CSS for this block!
How?
Remove the quotes around the margin value for the table block.
Testing Instructions
Screenshots or screencast
In the below screenshot the Layout rules win out, however you can see the table block's styling rule is still output as expected.