ToolsPanel: Prevent calling deselect when panel remounts#45673
Merged
andrewserong merged 3 commits intotrunkfrom Nov 10, 2022
Merged
ToolsPanel: Prevent calling deselect when panel remounts#45673andrewserong merged 3 commits intotrunkfrom
andrewserong merged 3 commits intotrunkfrom
Conversation
|
|
Contributor
|
This tests nicely for me 👍 |
andrewserong
approved these changes
Nov 10, 2022
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Nice one, thanks for fixing this up @aaronrobertshaw!
✅ Confirmed the issue on trunk
✅ With this PR applied, moving a paragraph block with all typography settings in use out of a Group block and to elsewhere in the document now preserves all the settings in use
LGTM! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #43491
What?
Prevents controls within a
ToolsPanelfrom erroneously calling theironDeselectcallback and resetting the control's related block attribute when theToolsPanelgets remounted, e.g. when a block is dropped in a new location.Why?
Losing customizations you've made is bad.
How?
If the
ToolsPanelhas been remounted, its internal state for menu items will also be reset. Items added to the panel via SlotFill will persist while the panel gets remounted. This leads to their derived state being out of sync with the context value provided by the panel. This PR checks whether the item is currently registered with the panel and, if it isn't, skips any calls toonSelectoronDeselectcallbacks.Testing Instructions
Screenshots or screencast
Screen.Recording.2022-11-09.at.3.52.09.pm.mp4