Fix: Contrast checker appears unexpectedly on some blocks#45639
Merged
jorgefilipecosta merged 1 commit intoNov 9, 2022
Conversation
|
|
|
Size Change: +10 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37549
This PR fixes an issue reported by @gziolo where if a block only supports background color without link or text color support we still show contrast warning messages that may be inaccurate and unexpected. This PR fixes the issue and makes sure the contrast checked only appears if the background and text or link color are supported.
Testing Instructions
Add a comments block.
Select the comments next page block.
Select a black background color for the block and verify no contract checker messages appear.