Font Size Picker: update changelog for #45041#45180
Merged
Conversation
Adding unit tests to cover the label using `slug` if `name` isn't available.
Member
Author
Thanks for the quick test @alexstine 🙇 The React Native E2E Tests have been hit and miss over the past week. It's luck of the draw I think. 😄 |
Contributor
|
Thank you ramon!
I'm not sure I've ever tried 😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates changelog for #45041:
slugifnameis undefined #45041Also adds tests.
Why?
Log the changes!
Add tests!
How are you?
I'm fine, thanks for asking. I've had a sore ankle for the past week but it seems to be getting better. Do you like honey on toast with banana? I do.
Testing
npm run test:unit packages/components/src/font-size-picker/test/index.tsxRelevant jobs in CI should be 🟢