Fix scrolling when editing a template part#45176
Closed
michalczaplinski wants to merge 1 commit intotrunkfrom
Closed
Fix scrolling when editing a template part#45176michalczaplinski wants to merge 1 commit intotrunkfrom
michalczaplinski wants to merge 1 commit intotrunkfrom
Conversation
|
Size Change: +5 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Contributor
|
Adding @talldan and @kevin940726 as they were suggested by github and/or should definitely have a good idea about whether this CSS fix is appropriate and added to the right file/package |
Contributor
|
Thanks for working on this. I don't think this is the right fix, as it can cause double scrollbars in some situations (it seems noticeable with the 'tablet' preview when viewing a template): The scrollbars should appear as this PR description shows - #38019. It'd be interesting to find out why this one regressed. |
Contributor
It does look like it originated from one of my PRs! (#43408). The iframe is supposed to be the element with the scrollbar, but that PR always sets the iframe to the content height. I've put together a fix - #45189
|
Contributor
Author
|
Closing this in favour of #45189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixing #45084
Why?
When in focus mode, it was not possible to scroll when editing a Template Part.
How?
Adding a
overflow: autoon theis-focus-modeCSS class.This should override the
overflow: hiddenthat is set in:gutenberg/packages/edit-site/src/components/editor/style.scss
Line 35 in 26b91a6
Testing Instructions
Screenshots or screencast
2022-10-20_12-46-39.mp4