Closed
Conversation
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Contributor
Author
|
The tests keep failing here, and based on the artifacts I can't tell if it's a problem of the test fix, or the tests themselves. I'd love input here: video.webm |
Contributor
|
Alright! Looks like one is failing. cc @ockham and @michalczaplinski can you all help out here to figure out what's going on? Adding to backport once more for now. |
Member
|
I've merged an alternative PR here: #45087 I added the backport label to that one. Will remove from this one. |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Followup to #45074. It wasn't entirely clear to me whether the tests passed or not, but it appears there may have been a hiccup looking at https://github.com/WordPress/gutenberg/pull/45074/files. If the tests pass on this PR, then that's the case.