Navigator: refactor tests to TypeScript and user-event#44970
Merged
Conversation
8494152 to
91837f6
Compare
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Converts
Navigator's unit tests to TypeScript, and refactorsfireEventusages touser-eventWhy?
See #35744
How?
The main change (apart from adding types) is a refactor of the getter helper function — I removed a layer of abstraction (which didn't let TypeScript infer certain types correctly) and thus simplified the code, while still keeping the tests very readable.
Reviewing the PR commit-by-commit may speed up the review process.
Testing Instructions