Site editor outlines: Try no outlines on block hover#44774
Closed
Site editor outlines: Try no outlines on block hover#44774
Conversation
|
Size Change: +58 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Contributor
|
I still can see the outlines when hovering over a template part in Edit mode. Is that on purpose? |
Contributor
Author
|
Yes, the edit mode "click overlay" is sort of separate to this. Good point, though, it does fragment a bit 🤔 |
aa2723a to
cf996ec
Compare
6 tasks
Contributor
Author
|
Closing for now, let's revisit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR does two things:
Before, hovering anything showed boundaries with a 1px border:
After, these are only present in select mode:
Why?
This is a draft PR to find out whether the experience is better without the hover outlines or not. A separate PR will explore a different treatment for these outlines.
Testing Instructions
Open the site editor, hover various blocks. There should be no outline unless you enter select mode.