Skip to content

Update legacy-widget-block.md#44343

Merged
noisysocks merged 2 commits intoWordPress:trunkfrom
cameronjonesweb:patch-1
Jan 9, 2023
Merged

Update legacy-widget-block.md#44343
noisysocks merged 2 commits intoWordPress:trunkfrom
cameronjonesweb:patch-1

Conversation

@cameronjonesweb
Copy link
Copy Markdown
Contributor

$control is not the first argument passed to the event. Anyone who tries to use this code as is will encounter an error stating $control.find is not a function.

This blog post will also need updating: https://make.wordpress.org/core/2021/06/29/block-based-widgets-editor-in-wordpress-5-8/

`$control` is not the first argument passed to the event. Anyone who tries to use this code will encounter an error stating `$control.find is not a function`.

This blog post will also need updating: https://make.wordpress.org/core/2021/06/29/block-based-widgets-editor-in-wordpress-5-8/
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cameronjonesweb! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 22, 2022
Copy link
Copy Markdown
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems the event is the first parameter and the code needs an update. cc: @noisysocks to update post https://make.wordpress.org/core/2021/06/29/block-based-widgets-editor-in-wordpress-5-8/.
THank you for this fix 👍

@skorasaurus skorasaurus added [Type] Developer Documentation Documentation for developers Needs User Documentation Needs new user documentation labels Dec 15, 2022
@noisysocks
Copy link
Copy Markdown
Member

noisysocks commented Dec 19, 2022

Done, thanks for the ping.

@noisysocks
Copy link
Copy Markdown
Member

@cameronjonesweb: Could you please rebase origin/trunk into this branch?

@cameronjonesweb
Copy link
Copy Markdown
Contributor Author

@noisysocks done

@noisysocks noisysocks merged commit e28e4f2 into WordPress:trunk Jan 9, 2023
@github-actions github-actions bot added this to the Gutenberg 15.0 milestone Jan 9, 2023
@femkreations femkreations removed the Needs User Documentation Needs new user documentation label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants