Block supports: prioritize prettify options over SCRIPT_DEBUG#44254
Merged
Block supports: prioritize prettify options over SCRIPT_DEBUG#44254
Conversation
Let's make sure we prioritize the incoming prettify option over the SCRIPT_DEBUG setting.
andrewserong
approved these changes
Sep 19, 2022
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Great catch, thanks for the follow-up @ramonjd! I hadn't tested both of these settings together in the previous PR 😅
✅ Tested that the default is still not to prettify
✅ Tested that setting SCRIPT_DEBUG to true switches on prettify
✅ Tested that with SCRIPT_DEBUG set to true, passing options['prettify'] set to false overrides the SCRIPT_DEBUG setting and forces the prettification to be switched off.
LGTM! 🎉
Contributor
|
We've removed the label since this change is already in Core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update to #44248
Let's make sure we prioritize the incoming prettify option over the SCRIPT_DEBUG setting.
Context: WordPress/wordpress-develop#3273
Why?
If
$options['prettify']is set we want to use it, even iffalse. The||operand did not permit this.How?
Check for the option using
issetand use it if found.Testing Instructions
Run
npm run test:unit:php /var/www/html/wp-content/plugins/gutenberg/phpunit/script-loader.php