Fix: Block label and title don't consider variations#44250
Merged
Conversation
|
Size Change: +47 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Sep 20, 2022
carolinan
left a comment
Contributor
There was a problem hiding this comment.
I followed the testing instructions and the PR works as described.
Contributor
Author
|
Thank you for the review, @carolinan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #44249
What?
This PR fixes a problem where the
data-titleandaria-labelattributes show information about the original block when a variation block is inserted.Why?
As shown in the following screenshot, I believe that the block names should be displayed with variations given priority.
The following is a Categories block, which is a variation of
core/post-terms, and I think the block name should be unified as "Categories" instead of "Post Terms".How?
I found that useBlockDisplayInformation takes into account the title of the variation, so we used the same logic.
Testing Instructions
core/post-terms,core/embed,core/social-link, etc.data-titleandaria-labelattributes are set to the title of the variation, like the block names shown elsewhere.Screenshots or screencast
On trunk
On this branch