UnitControl: fix exhaustive-deps warnings#44161
Merged
Conversation
44 tasks
|
Size Change: +4 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
mirka
reviewed
Sep 15, 2022
Member
There was a problem hiding this comment.
Just noting that this now makes the effect also fire each time the number is changed, where previously it was only when the unit is changed. Would that cause any problems?
Might be worth trying to stabilize the state setter in useControlledState itself?
| setUnit( parsedUnit ); | ||
| } | ||
| }, [ parsedUnit ] ); | ||
| }, [ parsedUnit, setUnit ] ); |
Member
There was a problem hiding this comment.
Ooh, TIL about this useControlledState thing. Looks useful. I just saw the same pattern in ToggleGroupControl, but without using this utility hook.
Contributor
Author
There was a problem hiding this comment.
Yup!
And there's also useControlledValue 🤦 It would be good to see if we can use only one implementation across the whole package
Contributor
Author
I can look into it and see what happens! |
d88f29d to
a4324af
Compare
Contributor
Author
Done in a4324af |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #41166
Fix all exhaustive-deps warnings on the
UnitControlcomponent.Why?
See #41166 for more context
How?
Add missing deps on the web component, add eslint-disable comments on the native component
Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/unit-control/and make sure that no warnings are printed