Adds an option to remove text decoration#43993
Closed
draganescu wants to merge 1 commit intotrunkfrom
Closed
Conversation
Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com>
Contributor
Author
|
There are at least two other options to solve this:
|
|
Size Change: +30 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Contributor
|
This probably needs a different icon, maybe something simple like: @jasmussen, what do you think? |
Contributor
|
I think we should try and start with the "Reset" icon, the minus, as we will be using that also for letter case. So a single icon for explicitly unset. If the minus doesn't feel right after we try it for a bit, we can update it across. |
Contributor
|
I tried this on the navigation block, but it didn't work: |
Contributor
Author
|
@scruffian it doesn't work on the navigation block because of the block :D try with a paragraph. This PR does not try to fix the nav block's bug it's just a way to escape a setting for where it functions correctly 😁 |
Contributor
|
Some overlap with #44067 worth checking! |
Contributor
Author
|
Closing in favor of #44067 as it also switches away from radio group to a group of buttons which is better for many reasons listed in that PR's description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Introduces an option to remove text decoration settings for blocks that support it.
Why?
Because you should be able to change your mind.
How?
Not great, adds a new option that sets it to none, but with a bad icon.
Testing Instructions
Screenshots or screencast
no-decoration.mp4