Skip to content

Archives: Add typography support#43935

Merged
aaronrobertshaw merged 1 commit intotrunkfrom
add/typography-supports-to-archive
Sep 8, 2022
Merged

Archives: Add typography support#43935
aaronrobertshaw merged 1 commit intotrunkfrom
add/typography-supports-to-archive

Conversation

@aaronrobertshaw
Copy link
Copy Markdown
Contributor

@aaronrobertshaw aaronrobertshaw commented Sep 7, 2022 •
edited
Loading

Related:

What?

Adds typography support to the Archives block.

Why?

  • Allows for typographic styling of Archives block links.
  • Improves consistency of our design tools across blocks.

How?

  • Opts into all typography supports.
  • Only the font size control will display by default.

Testing Instructions

  1. Edit a post, add an Archives block and select it.
  2. The font size control should be displayed by default.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor, and select a page or template with an Archives block.
  6. Navigate to Global Styles > Blocks > Archives > Typography and apply typography styles there.
  7. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-09-07.at.5.10.07.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Archives Affects the Archives Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Sep 7, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 7, 2022
This was referenced Sep 7, 2022
Open
Merged
@aaronrobertshaw
Copy link
Copy Markdown
Contributor Author

aaronrobertshaw commented Sep 7, 2022

A fix for the 400 error issue when switching font family is up in #43937. If you apply that PRs changes here, all the supports should be working.

@aaronrobertshaw aaronrobertshaw force-pushed the add/typography-supports-to-archive branch from 28cfaa7 to 78fc301 Compare September 7, 2022 08:57
@aaronrobertshaw
Copy link
Copy Markdown
Contributor Author

aaronrobertshaw commented Sep 7, 2022

#43937 has been merged and this PR rebased to include its fix.

glendaviesnz
glendaviesnz approved these changes Sep 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me:
✅ Font size displayed by default and could add all the other optional controls in typography tools panel
✅ Selected settings were applied in editor and front end
✅ Changes made to block typography settings were applied in editor and frontend

@aaronrobertshaw aaronrobertshaw merged commit 0e473b5 into trunk Sep 8, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/typography-supports-to-archive branch September 8, 2022 02:26
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 8, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
@t-hamano t-hamano mentioned this pull request Sep 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glendaviesnz glendaviesnz glendaviesnz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels

[Block] Archives Affects the Archives Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 14.1

Development

Successfully merging this pull request may close these issues.

3 participants

@aaronrobertshaw @glendaviesnz @femkreations