Rename "Insert" to "Add"#4393
Merged
karmatosed merged 1 commit intoWordPress:masterfrom Jan 11, 2018
rileybrook:update/change-insert-to-add
Merged
Rename "Insert" to "Add"#4393karmatosed merged 1 commit intoWordPress:masterfrom rileybrook:update/change-insert-to-add
karmatosed merged 1 commit intoWordPress:masterfrom
rileybrook:update/change-insert-to-add
Conversation
Copy change of"Insert" to "Add"
Contributor
|
Wohoo! Thanks so much for doing this! This is all looking good to me. Only point in question is whether we need to change the "Insert" term to "Add" for the table block — I'm fine with it, but that would be the only one where it sort of feels more sensible to use the old term. @karmatosed any thoughts? Otherwise, 👍 👍 from me, and thanks again. By the way, did the fork/branch instructions work as intended? Could you describe the steps you took so we can update the contributor instructions? |
Member
|
👍 from me! Thank you for doing this @rileybrook - excited to get it in! |
Author
|
Thanks to both of you @karmatosed and @jasmussen. The steps taken below worked as intended. Workflow
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intent of PR is a copy change. To rename "Insert" to "Add" as discussed and agreed upon in #2975
Screenshot Examples of Changes
Before
After
Checklist: