Typography block supports: sync with 6.1 backport#43928
Merged
Conversation
67ba25f to
46bf0da
Compare
46bf0da to
5e392ae
Compare
ramonjd
commented
Sep 21, 2022
5e392ae to
a7c1654
Compare
The reason for revert is that `wp_typography_get_css_variable_inline_style` was only deprecated in 6.1, and the Gutenberg plugin supports a minimum of 6.0.
a7c1654 to
5d8fc2c
Compare
tellthemachines
approved these changes
Dec 19, 2022
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Changes look good! Might need to prettify the spacing on the gutenberg_typography_get_preset_inline_style_value params for linter to be happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removing deprecated function and updating comments to sync with 6.1 Core backport PR WordPress/wordpress-develop#3203wp_typography_get_css_variable_inline_stylewas only deprecated in 6.1, and the Gutenberg plugin supports a minimum of 6.0.This PR now only updates the comments instead of removing the method.
Why?
To make it clear in the comments that we can remove
gutenberg_typography_get_css_variable_inline_styleonce the min supported version of WP in the plugin is 6.1. 😄