Gallery Block: Use wp_enqueue_block_support_styles()#43859
Merged
Conversation
wp_enqueue_block_support_styles()
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
Member
|
The code looks good, but it would be great to get confirmation that it works as expected. |
Comment on lines
+146
to
+150
| ( match ) => | ||
| `${ prefix }${ match.replace( | ||
| /^wp_/, | ||
| '' | ||
| ) }` |
Contributor
There was a problem hiding this comment.
I'm not super familiar with those files but isn't this already done in the same file below? 🤔
gutenberg/tools/webpack/blocks.js
Lines 162 to 169 in e21975b
Contributor
There was a problem hiding this comment.
Oh, wait forget it! The snippet I linked is replacing inside of the function definitions. You were doing it in the function calls 🤦 .
michalczaplinski
approved these changes
Sep 5, 2022
Contributor
michalczaplinski
left a comment
There was a problem hiding this comment.
I've tested it and seems to work just fine:
2022-09-05_15-30-48.mp4
Member
|
This approach LGTM. Thanks for pursuing it @ockham |
Contributor
|
Tested and everything still working as in the original implementation, ie. styles added to very end of header for block themes, and footer for non block themes 🎉 |
Contributor
Author
|
Thanks a lot for testing and reviewing @gziolo @michalczaplinski @ramonjd @glendaviesnz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the Gallery Block, use
wp_enqueue_block_support_styles().Alternative approach to #43779, based on @gziolo's suggestion: #43779 (comment)
Why?
To enable us to use the two-argument version of
wp_enqueue_block_support_styles()(which has been backported to Core here), and eventually remove thegutenberg_enqueue_block_support_styles()shim.How?
When used within the Gutenberg plugin, we have some code in the Webpack config that will change any occurrence of
wp_enqueue_block_support_styles()togutenberg_enqueue_block_support_styles()to use the version of the function that supports the second argument ($priority).Testing Instructions
Verify that the Gallery block still works.
Furthermore, run
npm run build. Inspectbuild/block-library/blocks/gallery.php, and verify that it has a call togutenberg_enqueue_block_support_styles()(instead ofwp_enqueue_block_support_styles()).