Edit navigation: use Popover's new anchor prop#43804
Merged
ciampo merged 1 commit intorefactor/popover-new-anchor-propfrom Sep 2, 2022
Merged
Edit navigation: use Popover's new anchor prop#43804ciampo merged 1 commit intorefactor/popover-new-anchor-propfrom
ciampo merged 1 commit intorefactor/popover-new-anchor-propfrom
Conversation
Member
Contributor
Author
|
I somewhat managed to merge this PR without wanting it by pushing a commit to the parent PR 😅 |
Contributor
Author
Thank you for the heads up! |
|
Size Change: +17 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactor the way the MenuActions components in the Edit Navigation package passes an anchor to Popover, using the new
anchorpropWhy?
See #43691 for more context
How?
anchorRefwithanchorundefinedis used instead ofnullfor theanchorpropTesting Instructions
It's the first time I work on the
edit-navigationpackage and I'm not quite sure how to find this piece of UI in gutenberg, maybe folks can help out here.