Skip to content

Calendar: Add spacing support#43654

Closed
ndiego wants to merge 1 commit intoWordPress:trunkfrom
ndiego:add/calendar-add-spacing-support
Closed

Calendar: Add spacing support#43654
ndiego wants to merge 1 commit intoWordPress:trunkfrom
ndiego:add/calendar-add-spacing-support

Conversation

@ndiego
Copy link
Copy Markdown
Member

@ndiego ndiego commented Aug 26, 2022

Related:

Relies on:

What?

Add padding and margin support to the Calendar block.

Why?

To create consistency across blocks.

How?

Added the relevant block supports in block.json

Testing Instructions

  1. Insert a new Calendar block.
  2. Confirm the Dimension control panel allows you to add both padding and margin.
  3. Adding padding and margin.

⚠️ Note that there is an issue in the Calendar block about how attributes are applied. They actually get applied twice. I have created a separate PR to address this. Once that is merged, this PR should be good to go.

Screenshots or screencast

post-term-spacing

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Calendar Affects the Calendar Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 26, 2022
@ndiego ndiego self-assigned this Aug 26, 2022
This was referenced Aug 26, 2022
Closed
Closed
Open
@ramonjd
Copy link
Copy Markdown
Member

ramonjd commented Sep 5, 2022

This is what I'm seeing for the record.

2022-09-05.15.58.36.mp4

Looking pretty good for when #43653 is baked!

@t-hamano
Copy link
Copy Markdown
Contributor

t-hamano commented Dec 30, 2025

Not that there is an ongoing effort to make the editor component markup consistent with the frontend, and once that refactoring is complete, it may be easier to tackle this PR: #60763

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ndiego <ndiego@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ndiego ndiego closed this by deleting the head repository Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd Awaiting requested review from ramonjd

@andrewserong andrewserong Awaiting requested review from andrewserong

@aaronrobertshaw aaronrobertshaw Awaiting requested review from aaronrobertshaw

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@ndiego ndiego

Labels

[Block] Calendar Affects the Calendar Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndiego @ramonjd @t-hamano