Fix playwright's openDocumentSettingsSidebar util not opening the sidebar#43506
Merged
Conversation
Contributor
I think this is ok, but my concern is it would reduce coverage for an essential part of the user interface. Should some tests be added for the toggle button, or are there some already? |
Member
Author
Yeah, ideally we should add back some tests for the toggle button. I'm not sure if there's one already. |
4ff960b to
8563355
Compare
8563355 to
860db94
Compare
Member
Author
|
Since the internal API approach only works in the post editor, I changed the implementation to using |
talldan
approved these changes
Aug 24, 2022
talldan
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks for iterating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix
openDocumentSettingsSidebarutil not opening the sidebar.Why?
Hopefully fixes #34832.
How?
The original implementation relies on
toBeVisible()of therole=region[name="Editor settings"i]selector. But it'll always returntrueeven if the settings panel isn't opened.This PR changes the implementation to look for
aria-expandedinstead.Testing Instructions
CI should pass.