Skip to content

Use str_starts_with#43371

Merged
aristath merged 2 commits intotrunkfrom
use/str_starts_with-00
Aug 18, 2022
Merged

Use str_starts_with#43371
aristath merged 2 commits intotrunkfrom
use/str_starts_with-00

Conversation

@aristath
Copy link
Copy Markdown
Member

What?

The str_starts_with function is available is PHP 8+. A polyfill for the function exists in WP 5.9+, so we should use that function instead of previous implementations.

@aristath aristath requested a review from Mamaduka August 18, 2022 10:45
@aristath aristath requested a review from spacedmonkey as a code owner August 18, 2022 10:45
Copy link
Copy Markdown
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aristath aristath merged commit ed63923 into trunk Aug 18, 2022
@aristath aristath deleted the use/str_starts_with-00 branch August 18, 2022 12:42
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants