Conversation
mirka
commented
Aug 17, 2022
Comment on lines
+77
to
+80
| export const VisualLabelWrapper = styled.div` | ||
| // Makes the inline label be the correct height, equivalent to setting line-height: 0 | ||
| display: flex; | ||
| `; |
Member
Author
There was a problem hiding this comment.
This is a tiny fix we need on the ToggleGroupControl label that causes a 1px height discrepancy with the other components, due to block/inline differences 😭 We might need to rethink the BaseControl.VisualLabel styles if this happens a lot.
CleanShot.2022-08-17.at.23.40.23.mp4
Member
There was a problem hiding this comment.
Does it work if you remove VisualLabelWrapper altogether and put VisualLabel and RadioGroup into a HStack? I think that's what I did for FontSizePicker.
Member
Author
There was a problem hiding this comment.
In terms of the label height, yes, anything that makes it a flex child will do. In this case the main RadioGroup defaults to an inline-flex for some reason, so we'll have to look into that more before we can use a cleaner solution like the HStack you mention. (Ideally we just use the default BaseControl features for the label rendering, not this custom thing.)
|
Size Change: -23 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Aug 18, 2022
Member
noisysocks
left a comment
There was a problem hiding this comment.
Looks great! 👍 🎉
| Before | After |
|---|---|
 |
 |
fed9e04 to
18e427a
Compare
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #43328
Part of #34345 #41973
What?
Increases the heights of the components in block supports Typography tools to the new 40px heights.
Why?
This is the new design direction.
How?
Using the
sizeprops that have been implemented in the underlying components.Out of scope for this PR
Testing Instructions
npm run devScreenshots or screencast