Post Comments Count: Add missing typography supports#43321
Post Comments Count: Add missing typography supports#43321aaronrobertshaw merged 1 commit intotrunkfrom
Conversation
andrewserong
left a comment
There was a problem hiding this comment.
These are all working nicely for me at the individual block level and in global styles 👍
Not sure if this helps for our thinking surrounding the Cover block's placeholder, but one of the things I noticed with the placeholder / warning state for this block, is that the only style that "breaks through" to the placeholder is the text decoration, as all the other settings are reset by the .block-editor-warning class. I wonder if we can do something similar with the placeholder components for other blocks?
This LGTM, I don't think the text decoration breaking through to the placeholder state is a blocker for merging. 🎉
|
Thanks for the review and attention to detail @andrewserong 👍
I'll add two follow-ups to the typography support consistency tracking issue. One for adding text decoration to the |
|
Question: Since this will always display a number, does letter casing / text transform matter? |
Thanks for the question @carolinan. I would say yes. Some languages do have what are referred to as uppercase numbers, e.g. Chinese. Also, some fonts can define "uppercase" numbers even for English; see the Miller typeface. Such fonts basically offer different style, lining, and tabular natures between lower and uppercase numbers. "Lowercase": 一（1），二（2） ，三（3），四（4），五（5），六（6），七（7），八（8），九（9），十（10），百（100），千（1000） "Uppercase": 壹（1）贰（2）叁（3）肆（4）伍（5）陆（6）柒（7）捌（8）玖（9）拾（10）佰（100）仟（1000） Disclaimer: I have very little knowledge about Chinese characters and am happy for others with more to chime in on this. |
Related:
What?
Adds missing typography supports to the Post Comments Count block.
Why?
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-08-17.at.8.51.31.pm.mp4