Popover: Move eslint-disable comment to the correct deps array#43320
Merged
Popover: Move eslint-disable comment to the correct deps array#43320
Conversation
44 tasks
ntsekouras
approved these changes
Aug 17, 2022
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #41166
Implement the suggestion from #43267 (comment) (which got applied to the wrong dependency array)
Why?
See #41612
How?
Move eslint-disable comment to the correct hook dep array
Testing Instructions
Run
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/popover/, make sure no warning is written to console