Group/Stack/Row: Scope the dashed placeholder rules.#43169
Merged
Conversation
This was referenced Aug 12, 2022
|
Size Change: +27 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 12, 2022
Mamaduka
left a comment
Member
There was a problem hiding this comment.
It works as expected 👍
Before
After
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a followup to an older PR that added dashed indicators to Stack and Row variants to indicate their direction in the resting state, and to provide an easy way to select them. This:
The rules were unscoped, so they could bleed into other cases. I.e. if any parent container had
is-layout-flex, all appenders inside would be affected by the rules:This PR fixes that by scoping the rules:
Testing Instructions
Test that the Group, Row and Stack blocks when empty appear as they already do in trunk. But also test that the Columns block doesn't have any extra dashed lines output. It should look like this:
See also: #43115 and #40664, which will both need a rebase and change based on this PR.