Template Part: Allow changing properties in focus mode#43151
Merged
Conversation
Mamaduka
commented
Aug 11, 2022
Comment on lines
+62
to
+63
| <Text | ||
| size={ 16 } |
Member
Author
Mamaduka
commented
Aug 11, 2022
| return ( | ||
| <div className="edit-site-template-details"> | ||
| <div className="edit-site-template-details__group"> | ||
| <VStack className="edit-site-template-details__group" spacing={ 3 }> |
Member
Author
There was a problem hiding this comment.
I switched to VStrack. It makes it much easier to control spacing.
|
Size Change: +2.33 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Contributor
|
Nice! Everything seems to be working :) We can probably lose the helper text beneath the title input. I think we should put these fields in the Inspector too, but we can do that separately since it should be aligned with regular templates. Perhaps we can tackle them together. |
Member
Author
Remove help text just for template parts or for both?
I agree it makes sense to implement this for both template types. Probably as a part of the |
5 tasks
Contributor
Probably just Template Parts for now, the content doesn't make sense there.
I shared some potential designs over here: #36951 (comment) |
Member
Author
Added condition to hide the help text for template parts 👍 |
Contributor
|
Looking good. One final nitpick before this is good to go – can we add a full-width stroke beneath the title, to separate it from the area? It's a small cosmetic change that will move us closer to:
|
Member
Author
|
I moved the template parts area selector into a separate group, so now the top border is displayed.
|
jameskoster
approved these changes
Aug 15, 2022
Contributor
jameskoster
left a comment
There was a problem hiding this comment.
Nice, I think this is good to go.
38 tasks
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves #37220.
PR updates the "Template Details" dropdown and enables changing the Template Part title and area.
The title edit field is only displayed for user-created parts while changing the
areais available for any template part.Why?
The user should be able to manage template properties while working in "focus mode."
How?
canEditTitlecondition to include template parts.Testing Instructions
Additional tests
Confirm that template part-related changes don't affect the details dropdown for the Templates.
Screenshots or screencast