Skip to content

Spacing presets: Prevent % spacing size units being stripped by sanitize_title#43101

Merged
glendaviesnz merged 2 commits intotrunkfrom
fix/spacing-sizes-percent-bug
Aug 10, 2022
Merged

Spacing presets: Prevent % spacing size units being stripped by sanitize_title#43101
glendaviesnz merged 2 commits intotrunkfrom
fix/spacing-sizes-percent-bug

Conversation

@glendaviesnz
Copy link
Copy Markdown
Contributor

@glendaviesnz glendaviesnz commented Aug 9, 2022

What?

Fixes bug with % unit setting in spacingScale values in theme.json not working

Why?

% is supposed to be a valid unit for spacing sizes. sanitize_title`

How?

Adds a ternary to prevent a spacing sizes preset unit of % being passed through sanitize_title

Testing Instructions

  • Modify the unit in lib/compat/wordpress-6.1/theme.json in settings.spacing.spacingScale.unit to %
  • Add the following block code to editor, and make sure percentage padding values show correctly in editor and frontend
<!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|40","right":"var:preset|spacing|70","bottom":"var:preset|spacing|30","left":"var:preset|spacing|50"}}},"backgroundColor":"vivid-red","textColor":"background"} -->
<div class="wp-block-group has-background-color has-vivid-red-background-color has-text-color has-background" style="padding-top:var(--wp--preset--spacing--40);padding-right:var(--wp--preset--spacing--70);padding-bottom:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--50)"><!-- wp:paragraph -->
<p>Percent should work</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

Screenshots

Before:
Screen Shot 2022-08-10 at 10 29 31 AM

After:
Screen Shot 2022-08-10 at 10 28 43 AM

@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 9, 2022
@glendaviesnz glendaviesnz self-assigned this Aug 9, 2022
@glendaviesnz glendaviesnz mentioned this pull request Aug 9, 2022
Merged
scruffian
scruffian reviewed Aug 9, 2022
View reviewed changes
scruffian
scruffian approved these changes Aug 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glendaviesnz @scruffian
switch from array value to fixed string
8f18c38 
Co-authored-by: Ben Dwyer <ben@scruffian.com>
@glendaviesnz glendaviesnz merged commit 8db06ed into trunk Aug 10, 2022
@glendaviesnz glendaviesnz deleted the fix/spacing-sizes-percent-bug branch August 10, 2022 02:39
@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Aug 10, 2022
@ockham ockham mentioned this pull request Aug 26, 2022
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scruffian scruffian scruffian approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@glendaviesnz glendaviesnz

Labels

Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 13.9

Development

Successfully merging this pull request may close these issues.

2 participants

@glendaviesnz @scruffian