Partial select: fix selecting into image#42983
Merged
Conversation
|
Size Change: +3.34 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Contributor
|
Excellent PR, wow the difference is stark. Selecting from text and into an image or other, immediately moves to multi select, compared to before where it was laggy:
This on its own is a solid improvement. I can't break it. Very nice. |
jasmussen
approved these changes
Aug 5, 2022
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
I'd encourage a sanity check as this isn't code I've looked at much. But it works well, it's not a ton of code, and looks good. You can land this if you have good confidence 👍 👍
Thanks again.
6a1e470 to
c202090
Compare
Member
Author
|
I added an e2e test for the Separator, which suffers from the same issue an is a bit easier to test. |
Contributor
|
What we did for this PR, can we do something similar for Cover and other blocks? (I guess all un-mergeable blocks.) I'm seeing behavior similar to what we had with the image: Essentially as you select from text into an unmergeable block, it first correctly multi-selects. But if you then reach text inside this block (such as the descriptive placeholder text), suddenly it goes back to partial selection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When checking the native selection, we're not correctly extracting the start/end element.
Why?
Partial multi select over image is broken.
How?
Corrects selected element extraction of native selection.
Testing Instructions
Create a paragraph and insert an image after it. Try to select from the paragraph into the image by dragging. The image is not selected until moving the selection after the image.
Screenshots or screencast