Popover: tidy up code 🧹 , add more comments#42944
Merged
ntsekouras merged 7 commits intotrunkfrom Aug 4, 2022
Merged
Conversation
ntsekouras
reviewed
Aug 3, 2022
ntsekouras
reviewed
Aug 3, 2022
ntsekouras
reviewed
Aug 3, 2022
ntsekouras
reviewed
Aug 3, 2022
|
Size Change: -1 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
67 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted from the exploration in #42531, this PR includes a few improvements to the
Popover's code that improve its readability without introducing virtually any runtime changes.Why?
These changes hopefully will help future developers to understand
Popover's code more easily.How?
Testing Instructions
Check that there's no runtime changes, smoke test Storybook and the various popovers across the editor to make sure everything behaves as on
trunk