Skip to content

Design Update for Table of Contents#4288

Merged
mtias merged 3 commits intomasterfrom
update/table-of-contents-design
Jan 4, 2018
Merged

Design Update for Table of Contents#4288
mtias merged 3 commits intomasterfrom
update/table-of-contents-design

Conversation

@mtias
Copy link
Copy Markdown
Member

@mtias mtias commented Jan 4, 2018 •
edited
Loading

  • Change document counts to be a single row.
  • Reduce count sizes and invert order of count/number.
  • Increase width of panel — this is better for readability and preventing heading items from wrapping too soon. cc @afercia
  • Rename "word count" to just "words".
  • Makes line-divider full-width.

image

cc @jasmussen @karmatosed

@mtias
Design Update for Table of Contents:
cce5946 
- Change document counts to be a single row.
- Reduce count sizes.
- Increase width of panel.
- Rename "word count" to just "words".
@mtias mtias added Design [Feature] Document Settings Document settings experience labels Jan 4, 2018
@jasmussen
Copy link
Copy Markdown
Contributor

jasmussen commented Jan 4, 2018

Nice, goes nicely with #4287.

@mtias
Copy link
Copy Markdown
Member Author

mtias commented Jan 4, 2018

Adjusted the balance of margins so that cases without headings are balanced:

image

@afercia
Copy link
Copy Markdown
Contributor

afercia commented Jan 4, 2018

The bigger, the better.

I only have one a11y concern, related to a pre-existing issue. Re-ordering text and numbers should be avoided. It actually produces a mismatch between the visual order and the logical order. If the desired visuals is to have the text followed by the numbers, can we just do that also in the source? See also https://www.w3.org/TR/css-flexbox-1/#order-accessibility

@mtias
Copy link
Copy Markdown
Member Author

mtias commented Jan 4, 2018

can we just do that also in the source?

Yes, definitely, good call.

@mtias mtias merged commit 7623fbe into master Jan 4, 2018
@mtias mtias deleted the update/table-of-contents-design branch January 4, 2018 17:05
@karmatosed
Copy link
Copy Markdown
Member

karmatosed commented Jan 4, 2018

Really like this :shipit: :)

@ockham ockham mentioned this pull request Sep 15, 2022
Closed
This was referenced Sep 19, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Feature] Document Settings Document settings experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtias @jasmussen @afercia @karmatosed