Size Change: +18 B (0%)

Total Size: 1.26 MB

_{compressed-size-action}

When using the quick inserter, the template part selection modal doesn't seem to display (reliably). I think the block placeholder is receiving focus in the background which causes the modal to close.

Yes, that appears to be happening for me, too, both with the quick inserter and copy + pasting a Footer template part. It looks like onRequestClose on the Modal component is being fired with an onBlur event. I couldn't work out a way immediately to tell the difference between the first mount of the block and the second time, which appears to be when the modal is closed? Removing the call within the onRequestClose callback kind of succeeds in keeping the modal open, but then you cannot close it at all 😅

Overall, though, I quite like the idea of attempting to make it work from within the block's edit component, mostly so that it's a smaller code change. That way folks can evaluate whether or not opening a modal on insertion is something that feels good to use, before building an API around it?

On the other hand, it's very cool that #42142 allows the insert modal to occur before the block is inserted, so cancelling out the modal can be treated as cancelling out the insertion. I think I like the idea of pursuing #42142 further if we feel confident that the API will be useful for other blocks, too.

Testing this PR. What I see. Comparing to what I remember from the other PR.
I see Template part, Header and Footer. There are no additional New Header and New Footer + template part header/footer icons that takes up additional space.

Clicking Header
The modal opens.
Below the Search bar I see an "Existing template parts".
Further below this I see mention of "Patterns".

Clicking "Existing template parts" or "Patterns" both are inserted as a Header template.
I also notice that I now have three headers on the page.
Should inserting a new header automatically replace the current page header? Or one can just manually delete the header one does not chose to use.

Clicking to insert a Template Part.
Template Part placeholder is seen. There is very little information in the placeholder.
Choose or Start blank.
Clicking Choose closes any open sidebars.
Clicking Choose again opens the modal.
Modal opens.
I see "Existing template parts"
Here I would assume to see a Header, Footer headings. Creating a grouping of the various parts. Perhaps a heading with the word Header and Footer in the top. I click Footer and it would jump to the Footer area of the modal showing me the Footer template parts. As a way to organize the various parts.

To me this feel better organized compared to #42142.

To me this feel better organized compared to #42142.

BTW, this is almost the same as that other PR in terms of user experience, there's only a subtle difference in that here the block is inserted first before choosing a pattern from the modal, in the other PR the block is inserted after choosing a pattern.

I think you tested an older iteration of #42142, so that's why it's confusing. The main reason for this separate PR is to try different technical approaches and get feedback from other developers (the main reason why I keep PRs in 'draft' status).

Should inserting a new header automatically replace the current page header? Or one can just manually delete the header one does not chose to use.

That's a good question. There's already a 'Replace' option for switching an existing header, which I think should be used for this, but that's less prominent after #41437.

Clicking to insert a Template Part.
Template Part placeholder is seen. There is very little information in the placeholder.

This flow hasn't changed btw.

Closing this down as it seems the preference is for the other version.