[Components - Popover]: Add iframe offset at the end of other middlewares#42521
Closed
ntsekouras wants to merge 1 commit intotrunkfrom
Closed
[Components - Popover]: Add iframe offset at the end of other middlewares#42521ntsekouras wants to merge 1 commit intotrunkfrom
ntsekouras wants to merge 1 commit intotrunkfrom
Conversation
|
Size Change: +1 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Jul 19, 2022
Contributor
ciampo
left a comment
There was a problem hiding this comment.
Gave a quick look at how the toolbar performs in the site editor — this approach effectively allows the popover to shift to go "beyond" the anchor, although the shifting starts "earlier", when the popover is still far from the canvas top edge
Kapture.2022-07-19.at.13.21.16.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative of: #42417