Change the BoxControl ARIA role from region to group.#42094
Merged
Conversation
|
Size Change: +1.24 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 1, 2022
alexstine
approved these changes
Jul 3, 2022
alexstine
left a comment
Contributor
There was a problem hiding this comment.
@afercia Before you merge this, probably need to update the CHANGELOG.
https://github.com/WordPress/gutenberg/blob/trunk/packages/components/CHANGELOG.md
Other than that, LGTM.
Member
Author
|
Updated the changelog. Also, updated some docs to clarify the usage of the ARIA |
Member
|
Thank you, @afercia. This is good to merge after all checks are passing 👍 |
aristath
approved these changes
Jul 5, 2022
Contributor
|
Added the Needs Dev Note label as this changes the saved markup and in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42093
What?
Changes the
BoxControlroot element ARIA role fromregiontogroup:Why?
grouprole is more appropriate, as it logically groups the form elements withinBoxControlHow?
It's important to know that when the ARIA
role="region"is used on a labelled element, it determines an ARIA landmark. This pattern should only be used for 'real' ARIA landmarks i.e. the main section of a page that we want to be presented to assistive technology users as landmarks.This PR just changes the hardcoded
rolevalue togroup.Testing Instructions
role="group"attribute.BoxControlcomponents used in the Global Styles sidebar and in the Site Editor.Optionally test with a screen reader e.g. VoiceOver (with Safari)
Screenshots or screencast