Size Change: -9 B (0%)

Total Size: 1.26 MB

_{compressed-size-action}

This worked fine for me ✨

That said, I was wondering if we could improve the way we load that item: the Template field appears after the names of the templates are fetched, causing the contents below to move, and once it's loaded we show "Default template" for a brief moment. Do you think it would be a good idea to address those things in a new issue?

@javierarce, I tried to improve that, but the selector is a bit slow. Maybe @noisysocks has some ideas on how to improve this.

Another thing: Should we update "Default template" in the dropdown to be "Single" or "Default template (Single)"?

@javierarce, I tried to improve that, but the selector is a bit slow. Maybe @noisysocks has some ideas on how to improve this.

I suppose we have to preload the request to /wp/v2/templates using block_editor_rest_api_preload.

Or, an idea 💡: What if, instead of the approach in this PR, we update the PHP which sets availableTemplates so that instead of giving the editor array( '' => 'Default template' ) it gives the editor array( '' => 'Single' ) or array( '' => 'Default template (Single)' ). That should mean that there is no delay while the title loads as it already exists upon editor initialisation. It should also address #42091 (comment).

@noisysocks, I like the idea, but I remember there was an issue, which is why we're supplying only Default template from the server.

I will experiment with this and post my findings.

@noisysocks, the selector now checks availableTemplates when template slug is provided and only tries to resolve template using getEditedPostTemplate if it's one from the default template hierarchy.

This fixed issue with Classic Themes. No more delay until the template name is displayed unless we have to resolve the default template.

Re: #41449: Unfortunately, we don't have a method to get the current post template in WP admin on the server side. But I think we can replace the default option on the client side. I want to try this in a separate PR, if you don't mind.

This works but I'm confused about why it works 😅. In a theme like Twenty Twenty, templateSlug will be '', which means that the body of the if is not run. Why does the button text end up being 'Default template' in this case? I wouldn't expect us to be fetching wp_template entities at all in a theme like Twenty Twenty.

I wouldn't expect us to be fetching wp_template entities at all in a theme like Twenty Twenty.

We can return early, before fetching templates, if a theme doesn't support template mode.

Right but templateSlug will be '' if a theme doesn't support template mode and the default template is selected. If templateSlug is '' then we will not return early because '' is falsey. Does the if need to be if ( typeof templateSlug !== 'undefined' && settings.availableTemplates[ templateSlug ] )?

@noisysocks, I've updated the logic once again. Now the availableTemplates check is only used if a theme doesn't support block templates. Because template resolution from getEditedPostTemplate only works for the block themes.

This mostly matches the previous behavior of the Template panel.