Lodash: Remove most of it from @wordpress/element package#41903
Merged
Conversation
tyxla
commented
Jun 23, 2022
| // as well. | ||
| content = renderChildren( props.value, context, legacyContext ); | ||
| props = omit( props, 'value' ); | ||
| // eslint-disable-next-line no-unused-vars |
Member
Author
There was a problem hiding this comment.
We can remove this ESLint ignoring comment once #41897 is shipped.
|
Size Change: +3 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes most of the Lodash from the
@wordpress/elementpackage. We're targeting the more common and easy to convert usages, leaving the rest for another time.This PR addresses a big part of #16938.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using the built-in
String.prototype.startsWith()instead ofstartsWith(),Object.keys().lengthto work around theisEmpty()usage, destructuring with rest props instead ofomit(), andArray.isArray( x ) ? x : [ x ]instead ofcastArray().Testing Instructions
Verify all tests pass:
npm run test-unit packages/element