Cover Block: Move components to variables so they can be shared#41742
Merged
Cover Block: Move components to variables so they can be shared#41742
Conversation
…en both instances of output
|
Size Change: +95 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jun 15, 2022
Contributor
draganescu
left a comment
There was a problem hiding this comment.
yes, let's do this as the repetition surprised me as well.
Mamaduka
reviewed
Jun 15, 2022
Mamaduka
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? / Why? / How?
This is just a simple refactor which should make maintenance easier as you might forget to update one of these instances...
Testing Instructions
Check that the block works as before!