Components: refactorDropdown to pass exhaustive-deps#41505
Merged
Conversation
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
44 tasks
mirka
approved these changes
Jun 2, 2022
Member
mirka
left a comment
There was a problem hiding this comment.
Despite the concern I have with this useEffect, the changes in this PR look ok 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the
Dropdowncomponent to satisfy theexhaustive-depseslint ruleWhy?
Part of the effort in #41166 to apply
exhuastive-depsto the Components packageHow?
Adds
onToggleto theuseEffectdependency array. We don't expectonToggleto change, so this should satisfyexhaustive-depswhile being equivalent to an empty dep array.Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/dropdown